Repository navigation
fix: Nullable.GetValueOrDefault() writes Lua that does not load - #533
Open
mdlsvensson wants to merge 1 commit into
Open
mdlsvensson wants to merge 1 commit into
mdlsvensson wants to merge 1 commit into
Conversation
The template used the method's type argument ({`0}), which GetValueOrDefault() has none of, so it was written as (n or:default()), which is not Lua. It now uses Nullable<T>'s type argument ({``0}).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is written as
which is not Lua, so the script does not load.
The template in
System.xmltook the method's own type argument, andGetValueOrDefault()has none. It now takes the type argument ofNullable<T>:which gives
(n or System.Int32:default()).Test:
NullableTests.GetValueOrDefaultWorks. CI passes: https://github.com/wc3-dev/CSharp.lua/actions/runs/44585226151