Conversation
|
Related PR xdit-project/DistVAE#3 To consider DP, we add
Then use default group to complete parallel vae. When using parallel vae, only one process need to process img after vae. So |
|
I think it is not a elegant implementation because you combined all the dp latents into one tensor instead of using different dp groups to process different latent. It will increase the communication load. |
It is indeed not the best implementation. Using different dp groups need to refactor DistVAE. Since parallel vae is an option, maybe we can first fix parallel vae in this PR, and further optimize it in the future. |
related to #271