Scale to 0 if <0 #67
Merged
Scale to 0 if <0 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents possible ValueError exceptions
Owner
|
Ah, yes. Great fix. Should have done that in the first place. Thanks! |
Contributor
Author
|
This change seems to have vanished from develop and master. Was this intended and there was an issues with this? |
Owner
|
Odd, it appears git has somehow reverted it... I'll re-add it :) |
Contributor
Author
|
While 3.9.3 contains this fix now, it's gone again in master and develop. |
Owner
|
I haven't done a force push so I'm guessing something went wrong when merging (I generally do rebase merges) but I'm not entirely sure what... I've merged everything back so it's now included again including a few extra tests to make sure it won't break again :) Thanks for all the help @TimoRoth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents possible ValueError exceptions