Skip to content

Conversation

@hroff-1902
Copy link
Contributor

Resolves #226

@hroff-1902
Copy link
Contributor Author

have no idea why CI checks failed (seems it's not related to the fix itself)

@wolph
Copy link
Owner

wolph commented Apr 20, 2020

Appveyor breaks itself on a regular basis unfortunately, no need to worry about it :)
At least Travis doesn't have any issues so I'm not worried: https://travis-ci.org/github/WoLpH/python-progressbar/builds/677184760

Anyhow, good fix. This fixes the integer truncation nicely. Thank you!

@wolph wolph merged commit 8255da0 into wolph:develop Apr 20, 2020
@hroff-1902 hroff-1902 deleted the patch-1 branch April 20, 2020 10:52
wolph added a commit that referenced this pull request Apr 20, 2020
Fixed #227, percentage rounding issue thanks to @hroff-1902 v3.51.0

# gpg: Signature made Mon Apr 20 12:52:37 2020 CEST
# gpg:                using RSA key 149325FD15904E9C4EB89E95E81444E9CE1F695D
# gpg: Good signature from "Rick van Hattem <[email protected]>" [ultimate]
# gpg:                 aka "[jpeg image of size 9662]" [ultimate]
@wolph
Copy link
Owner

wolph commented Apr 20, 2020

I've created a new release

wolph added a commit that referenced this pull request Feb 2, 2025
Resolve percentage rounding issue
wolph added a commit that referenced this pull request Feb 2, 2025
Fixed #227, percentage rounding issue thanks to @hroff-1902 v3.51.0

# gpg: Signature made Mon Apr 20 12:52:37 2020 CEST
# gpg:                using RSA key 149325FD15904E9C4EB89E95E81444E9CE1F695D
# gpg: Good signature from "Rick van Hattem <[email protected]>" [ultimate]
# gpg:                 aka "[jpeg image of size 9662]" [ultimate]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rounding issue

2 participants