Repository navigation
pi-phase trial instrumentation - #98
Merged
Merged
Conversation
Owner
Author
|
Reviewer notes: full review round 1 found one blocker (trailing-Z timestamps on Python < 3.11), fixed in fef1600; quick round 2 passed. pi-phase suite: 565 tests passed at 749709a; after the fix the suite hit 3 multi-process timing failures at host load ~160 (queue order, two slots, worktree lock), all passing on targeted rerun; the fix only touches timestamp parsing. Trials (baseline, hang 240s subset, 5x3 vs 4x2) run after install and are tracked on #93. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
trialinconfig.local.jsonmarks a trial window (name, arm, start). Every phase record carries it, andpi-phase report --trial NAMEsummarises each window and arm: throughput while queued, p50/p95 queue-plus-run time by kind, timeouts, swap growth, peak memory, CPU time and workload mix. (part of pi-phase: measured concurrency, hang-timeout and fast-admission trials #93)hang_timeoutgains anobservemode and alabelsscope. Observe records which phases the hang timeout would apply to without changing their command, and applied phases that end on a hang signature are recorded as hang kills. (part of pi-phase: measured concurrency, hang-timeout and fast-admission trials #93)pi-phase reportshows its prediction error and how its verdicts compare with today's fast-lane decisions. (part of pi-phase: measured concurrency, hang-timeout and fast-admission trials #93)Fixed
dotnetstarted by an explicit path, which bypasses the MSBuild worker cap, is now recorded and priced as using all cores instead of the cap. (part of pi-phase: measured concurrency, hang-timeout and fast-admission trials #93)