Release 2.6.0 #237
Merged
Release 2.6.0 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswerkmeister
approved these changes
Sep 15, 2017
manicki
reviewed
Sep 18, 2017
| `OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH`, | ||
| and added `OPTION_SERIALIZE_SNAKS_WITHOUT_HASH` instead | ||
| `OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH`. | ||
| * Added `SerializerFactory::OPTION_SERIALIZE_SNAKS_WITHOUT_HASH`. |
Member
There was a problem hiding this comment.
Just leaving a note that this change does not really seem related/necessary to me but whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that #222 should be in this release!
I used the opportunity to lower the line length a little bit, to a limit where I only had to touch two lines in a single file. I ended touching a few more lines because I decided to rename some variables (I found $snakDeserializerMock and $snaksDeserializerMock especially confusing – the only difference was an "s" in the middle of the variable name).