Release 2.4.0 #218
Merged
Release 2.4.0 #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
250f85b to
e4d7cb8
Compare
Contributor
|
This updated requirement kinda sucks. Is it really needed? If the only compat issue here is in the tests of this component, then you can resolve it there, without effecting users of this component that do not care about the hash. |
Contributor
Author
|
I also was not happy with this. I had an other look and believe I found a really nice solution. What do you think? |
bekh6ex
reviewed
Mar 16, 2017
|
|
||
| protected function buildSerializer() { | ||
| return new SnakSerializer( new DataValueSerializer() ); | ||
| return new SnakSerializer( new DataValueSerializer(), false ); |
There was a problem hiding this comment.
Could you name this false? Otherwise it quiet hard to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.