Skip to content

Conversation

@thiemowmde
Copy link
Contributor

Usually I would avoid "magical" behavior like this. For example, this must not be done in the Map base class. It should be possible to store null in a map. A generic map should not have such a magical value.

But labels, descriptions and aliases do have a specific type.

And most important: The getters return null. The setters should accept everything the getter returns.

@mariushoch
Copy link
Member

Sounds sensible to me and the implementation looks good. Would like another opinion, though.

@thiemowmde thiemowmde modified the milestone: 3.0.0 Aug 1, 2016
@JonasKress JonasKress merged commit 6c0ee19 into master Aug 1, 2016
@JonasKress JonasKress deleted the addNull branch August 1, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants