Remove unused filtering from getQualifiers #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c032bd to
125720b
Compare
Member
|
+1: getQualifiers parameter is indeed unused and removing it is in line with the PHP implementation. Not sure how to make sure the |
Contributor
Author
|
Simply search for |
Merged
125720b to
d36d7bd
Compare
mariushoch
added a commit
that referenced
this pull request
Jan 12, 2016
Remove unused filtering from getQualifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of an other cloning (see #47). But this one is currently not used outside of tests.
getFilteredSnakListshould do exactly that and not have a special case when the filter is a falsy value.getQualifiersshould do exactly that and not do optional filtering.If you want filtering, call
getQualifiers().getFilteredSnakList( propertyId ).