Merged
Conversation
1. Extract HTTPS handling in nginx.conf into its own `.lua` file 2. Configure log level according to `CERYX_DEBUG` 3. Introduce several debugging logs
akalipetis
reviewed
Jan 26, 2019
Contributor
akalipetis
left a comment
There was a problem hiding this comment.
LGTM in general, nice additions! I have added some minor comments and then it should be g2g.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CERYX_DEBUGinto account in CeryxCERYX_DISABLE_LETS_ENCRYPTfrom now on does not even load the Let's Encrypt automatic certificates code at all.CERYX_FALLBACKroute, so that it works even if DNS is messed up