Repository navigation
Remove mutation events from the spec - #10573
Conversation
The html spec only mentioned mutation events a handful of times, but now that they [have been removed from some browsers](whatwg/dom#305 (comment)) it feels safe to remove these mentions from the spec.
This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1345088}
This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1345088}
This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1345088}
domenic
left a comment
There was a problem hiding this comment.
Nice! LGTM with nit.
I'll give others a few days to comment as well.
Given your good point about origin trials and dates, do you think I should just hold off on filing implementation bugs? |
| .</p> | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This looks like it removes too many newlines, but maybe it makes it more consistent?
There was a problem hiding this comment.
Yeah, that's kind of why I removed those - they seemed extra. I can put them back if you tell me how many blank lines would be correct?
There was a problem hiding this comment.
One day we will have automatic formatting for newlines before headings, but until we do, the document is very inconsistent, so I'm OK to merge without fixing this.
|
Yeah, I think Gecko and WebKit can get an implementation bug when we decide the whatwg/dom issue is good. Gecko might also already have one. I think it's still okay to merge this given that it's highly likely going to succeed and given that mutation events weren't much specified to begin with. |
Sounds good, thanks! |
… a=testonly Automatic update from web-platform-tests Add mutation events to "historical" WPT This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1345088} -- wpt-commits: e0c3477d2cff8aaaefd421ca6543198ec30dc3ef wpt-pr: 47727
… a=testonly Automatic update from web-platform-tests Add mutation events to "historical" WPT This set of tests goes along with this spec PR: whatwg/html#10573 Bug: 40268638 Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1345088} -- wpt-commits: e0c3477d2cff8aaaefd421ca6543198ec30dc3ef wpt-pr: 47727
The html spec only mentioned mutation events a handful of times, but now that they have been removed from some browsers it feels safe to remove these mentions from the spec.
Closes whatwg/dom#305
/common-dom-interfaces.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/interactive-elements.html ( diff )
/parsing.html ( diff )
/xhtml.html ( diff )