Repository navigation
Conversation
huningxin
left a comment
There was a problem hiding this comment.
Should we also document the current Uint16Array solution before Float16Array landing? Maybe do it in a separate PR, any thoughts?
|
@huningxin thanks, that's a good idea. Updated the PR to note the Float16Array emulation path that demonstrably works. |
- Note TC39 Float16Array proposal is WIP - Update issue links Related #373 (Bikeshed syntax not supported inside tables, thus plain HTML.)
|
PR updated to reflect the (The second force-push was just to fix the commit message.) |
- Add {{Float16Array}} Bikeshed custom definition
- Convert the related in-spec issue into a note
- Tweak the note wording
|
@huningxin @wchao1115 PTAL. Please prioritize the review of this small patch. I'd be happy for our WG to be the early adopter of Float16Array given our ECMA friends defined this in part per our request (see #373). This paves the way for other new kinds of TypedArrays in the future beneficial to ML workloads. |
| </table> | ||
|
|
||
| Issue(webmachinelearning/webnn#127): clarify the usage of {{ArrayBufferView}} for {{MLOperandType/float16}}. | ||
| <p class="note">{{Float16Array}} is at <a href="https://tc39.es/process-document/">ECMA Stage 3</a> signalling its design is finished. Implementers wanting to enable this type ahead native implementations can emulate the type by passing raw bits via {{Uint16Array}}. <a href="https://github.com/webmachinelearning/webnn/issues/373">[Issue webnn#373]</a></p> |
There was a problem hiding this comment.
Please fix a typo "signalling"
We try to use en-US over en-GB for this spec.
|
With two approvals, I'll merge this PR to address our first v2 feature #373. |
SHA: 1a308dd Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…at16 SHA: 1a308dd Reason: push, by zolkis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This is an update to the compatibility table to note the latest status of float16 per discussion in #373.
(Bikeshed syntax not supported inside tables, thus plain HTML.)
Preview | Diff