Repository navigation
"Unidirectionally broadcast the shapes" steps have issues #662
Description
Activity
- changed the title
[-]"Unidirectionally broadcast the shapes" steps should allow smaller shapeA be broadcasted to larger shapeB[/-][+]"Unidirectionally broadcast the shapes" steps have issues[/+]on Apr 29, 2024 Did I just get the inputs reversed?
Did I just get the inputs inverted?
It seems. But the following step is correct:
If dimA is not equal to dimB and dimA is not equal to 1, then return failure.
I am making a PR to fix it, will upload soon.
Reacted by Joshua Bell- added a commit that references this issue
on Apr 29, 2024
The current unidirectionally broadcasting the shapes steps don't allow
sizeA<sizeBaccording to the following stepAnd the steps should pad
shapeA, the current steps padshapeBinsteadThis would cause the following examples to fail
[], ShapeB[3, 4, 5][5], shapeB[3, 4, 5]When creating the output shape, the steps should use
dimB. The current step usesdimA:This would produce incorrect output shape. For example, assume ShapeA
[3, 1, 5], ShapeB[3, 4, 5], the output shape should be[3, 4, 5], the current steps produce[3, 1, 5].