Repository navigation
Generate the app's dead theme color utilities - #517
Merged
Merged
Conversation
This was referenced Oct 30, 2026
bg-sideBarBackground is used in eight places, but tailwind.css defined no sideBarBackground token, so Tailwind never generated the class and those elements had no background. It showed where nothing paints behind: the live dashboard's start screen rendered light text on white in dark mode. Three text utilities (descriptionForeground, disabledForeground, inputForeground) had the same gap; their tokens are added too, so those elements take the colors their authors chose. A test scans the app for camelCase color utilities, which can only be ours since Tailwind's palette is lowercase, and fails on any without a token. Closes #504 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vishnuv688
force-pushed
the
test/510-trace-format-fixtures
branch
from
October 30, 2026 10:12
85c12cd to
857f076
Compare
vishnuv688
force-pushed
the
fix/504-sidebar-background
branch
from
October 30, 2026 10:12
831b6a1 to
8211eee
Compare
vishnuv688
changed the base branch from
test/510-trace-format-fixtures
to
main
November 2, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #504. Part of #494. Stacked on #515.
bg-sideBarBackgroundis used in eight places in the app, buttailwind.cssdefined nosideBarBackgroundtoken, so Tailwind never generated the class and those elements had no background. It showed where nothing paints behind them: the live dashboard's start screen rendered light text on a white page in dark mode, and the hosted player's landing screen needed a workaround. Three text utilities had the same gap.Type of change
Packages touched
shared(types and contracts)core(framework-agnostic capture/reporting)elements(published element/snapshot API —@wdio/elements)service(WebdriverIO adapter)nightwatch-devtools(Nightwatch adapter)selenium-devtools(Selenium adapter)selenium-devtools-py(Selenium Python adapter)backend(server)app(UI)script(page-injected runtime)trace(Trace mode)Capability matrix
packages/conformance/src/features.tsupdated, and tables regenerated withpnpm docs:capabilities, if this adds or changes user-facing behaviourNot needed: styling only.
Notes for reviewers
What changed
tailwind.cssgainssideBarBackground,descriptionForeground,disabledForegroundandinputForegroundtokens. The built CSS now contains.bg-sideBarBackground, which it did not before.snapshot-styles.tsalready paints those colors, so the dots look the same.tabs.tssaying these utilities generate no CSS is removed.theme-tokens.test.tsscans the app for camelCase color utilities (Tailwind's own palette is lowercase, so a camelCase name can only be ours) and fails on any without a token. It fails on the oldtailwind.cssand checks its scan found something, so it cannot pass vacuously.Visible changes, light / dark
#f3f3f3/#14171c. The biggest visible changeTesting
pnpm build,pnpm test(3338 passed) andpnpm lintare green.Needs checking by eye, in both themes (header toggle)
pnpm --filter @wdio/devtools-app build && pnpm --filter @wdio/devtools-app preview(no backend, so it stays up). Grey, not white; readable in dark.pnpm demo:wdio: the sidebar's "TESTS" heading and icons are still legible; collapse the actions sidebar and the dock and check both restore buttons at rest and on hover.pnpm player:hosted: landing screen unchanged; open a trace and check the speed select.Not in this PR:
src/core/shadow-styles.csscarries its own@import "tailwindcss"and a second@theme, so every component's styles include a second Tailwind build, andtailwind.config.jslooks unused under Tailwind v4. Worth a separate cleanup.Screenshots / recordings
To be added: before and after of the start screen and the restore buttons, in both themes.
🤖 Generated with Claude Code