Skip to content

Generate the app's dead theme color utilities - #517

Merged
vishnuv688 merged 1 commit into
mainfrom
fix/504-sidebar-background
Nov 2, 2026
Merged

vishnuv688 merged 1 commit into
mainfrom
fix/504-sidebar-background

Conversation

@vishnuv688

Copy link
Copy Markdown
Member

What & why

Closes #504. Part of #494. Stacked on #515.

bg-sideBarBackground is used in eight places in the app, but tailwind.css defined no sideBarBackground token, so Tailwind never generated the class and those elements had no background. It showed where nothing paints behind them: the live dashboard's start screen rendered light text on a white page in dark mode, and the hosted player's landing screen needed a workaround. Three text utilities had the same gap.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Polish (an improvement to an existing feature)
  • Breaking change (existing behavior changes for users)
  • Documentation
  • Internal (build, CI, dependencies, tooling)

Packages touched

  • shared (types and contracts)
  • core (framework-agnostic capture/reporting)
  • elements (published element/snapshot API — @wdio/elements)
  • service (WebdriverIO adapter)
  • nightwatch-devtools (Nightwatch adapter)
  • selenium-devtools (Selenium adapter)
  • selenium-devtools-py (Selenium Python adapter)
  • backend (server)
  • app (UI)
  • script (page-injected runtime)
  • trace (Trace mode)

Capability matrix

  • packages/conformance/src/features.ts updated, and tables regenerated with pnpm docs:capabilities, if this adds or changes user-facing behaviour

Not needed: styling only.

Notes for reviewers

What changed

  • tailwind.css gains sideBarBackground, descriptionForeground, disabledForeground and inputForeground tokens. The built CSS now contains .bg-sideBarBackground, which it did not before.
  • The hosted landing screen drops its workaround and uses the class.
  • The browser frame's three window dots lose three classes that named tokens that never existed; snapshot-styles.ts already paints those colors, so the dots look the same.
  • A stale comment in tabs.ts saying these utilities generate no CSS is removed.
  • theme-tokens.test.ts scans the app for camelCase color utilities (Tailwind's own palette is lowercase, so a camelCase name can only be ours) and fails on any without a token. It fails on the old tailwind.css and checks its scan found something, so it cannot pass vacuously.

Visible changes, light / dark

Where Before After
Live dashboard start screen white page in both themes (light text on white in dark) #f3f3f3 / #14171c. The biggest visible change
"Restore actions sidebar" button (sidebar collapsed) transparent over the snapshot backdrop solid sidebar-colored tile
"Restore dock" button (dock collapsed) transparent, can sit over replayed page content solid tile. On hover the 31%-opaque hover color replaces it, so it goes partly see-through again
Player speed select transparent over the controls bar a subtle raised chip
Sidebar "TESTS" heading, pending circles, chevrons, "No tests" text full foreground color dimmer, as their classes always intended. "TESTS" at 50% alpha may be low contrast
Tab bar, browser frame and headers, device frame header, hosted landing screen already painted by other rules unchanged

Testing

pnpm build, pnpm test (3338 passed) and pnpm lint are green.

Needs checking by eye, in both themes (header toggle)

  1. Start screen: pnpm --filter @wdio/devtools-app build && pnpm --filter @wdio/devtools-app preview (no backend, so it stays up). Grey, not white; readable in dark.
  2. pnpm demo:wdio: the sidebar's "TESTS" heading and icons are still legible; collapse the actions sidebar and the dock and check both restore buttons at rest and on hover.
  3. pnpm player:hosted: landing screen unchanged; open a trace and check the speed select.

Not in this PR: src/core/shadow-styles.css carries its own @import "tailwindcss" and a second @theme, so every component's styles include a second Tailwind build, and tailwind.config.js looks unused under Tailwind v4. Worth a separate cleanup.

Screenshots / recordings

To be added: before and after of the start screen and the restore buttons, in both themes.

🤖 Generated with Claude Code

bg-sideBarBackground is used in eight places, but tailwind.css defined no
sideBarBackground token, so Tailwind never generated the class and those
elements had no background. It showed where nothing paints behind: the live
dashboard's start screen rendered light text on white in dark mode. Three
text utilities (descriptionForeground, disabledForeground, inputForeground)
had the same gap; their tokens are added too, so those elements take the
colors their authors chose.

A test scans the app for camelCase color utilities, which can only be ours
since Tailwind's palette is lowercase, and fails on any without a token.

Closes #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vishnuv688
vishnuv688 force-pushed the test/510-trace-format-fixtures branch from 85c12cd to 857f076 Compare October 30, 2026 10:12
@vishnuv688
vishnuv688 force-pushed the fix/504-sidebar-background branch from 831b6a1 to 8211eee Compare October 30, 2026 10:12
@vishnuv688
vishnuv688 changed the base branch from test/510-trace-format-fixtures to main November 2, 2026 09:29
@vishnuv688
vishnuv688 merged commit 27392d2 into main Nov 2, 2026
7 checks passed
@vishnuv688
vishnuv688 deleted the fix/504-sidebar-background branch November 2, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App: bg-sideBarBackground is never generated, so 8 elements have no background

1 participant