Repository navigation
[Origin API] Drop Location and WorkerLocation conversions. - #56226
Merged
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
November 25, 2025 11:34
After discussion with Anne in [1], it makes sense to drop conversions from `Location` and `WorkerLocation` objects via `Origin.from()`. Those can meaningfully differ from the origin of the context to which they belong due to sandboxing, and we should encourage developers to use the right `Origin` representation going forward. [1]: whatwg/html#11846 (comment) Bug: 434131026 Change-Id: Ie8101ac9743767a32c109b83bdc82c9bb715d3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7186344 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1549657}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7186344
branch
from
November 25, 2025 11:34
fd29ae3 to
25e7733
Compare
wpt-pr-bot
approved these changes
Nov 25, 2025
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion with Anne in 1, it makes sense to drop conversions
from
LocationandWorkerLocationobjects viaOrigin.from(). Thosecan meaningfully differ from the origin of the context to which they
belong due to sandboxing, and we should encourage developers to use the
right
Originrepresentation going forward.Bug: 434131026
Change-Id: Ie8101ac9743767a32c109b83bdc82c9bb715d3b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7186344
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549657}