Skip to content

Another test of a branch on the same repo for spackbot - #17

Open
vsoch wants to merge 2 commits into
developfrom
another-needs-fix
Open

vsoch wants to merge 2 commits into
developfrom
another-needs-fix

Conversation

@vsoch

@vsoch vsoch commented Jul 14, 2021

Copy link
Copy Markdown
Owner

Signed-off-by: vsoch vsoch@users.noreply.github.com

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@spack-bot-develop

Copy link
Copy Markdown

It looks like you had an issue with style checks! To fix this, you can run:

$ spack style --fix

And then update the pull request here. Or you can just say @spackbot fix style and I'll do it!

@vsoch

vsoch commented Jul 14, 2021

Copy link
Copy Markdown
Owner Author

@spackbot hello!

@spack-bot-develop

Copy link
Copy Markdown

Hello!

@vsoch

vsoch commented Jul 14, 2021 •

Copy link
Copy Markdown
Owner Author

@spackbot re-run pipeline

@spack-bot-develop

Copy link
Copy Markdown

I've started that pipeline for you!

2 similar comments
@spack-bot-develop

Copy link
Copy Markdown

I've started that pipeline for you!

@spack-bot-develop

Copy link
Copy Markdown

I've started that pipeline for you!

@spack-bot-develop

Copy link
Copy Markdown

I've started that pipeline for you!

@spack-bot-develop

Copy link
Copy Markdown

It looks like you had an issue with style checks! To fix this, you can run:

$ spack style --fix

And then update the pull request here.

@vsoch

vsoch commented Jul 19, 2021

Copy link
Copy Markdown
Owner Author

@spackbot fix style

@spack-bot-develop

Copy link
Copy Markdown

Let me see if I can fix that for you! This might take a moment...

@spack-bot-develop

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack:
  selected: isort, mypy, flake8
==> Modified files:
  lib/spack/spack/url.py
==> Running isort checks
  Fixing /tmp/tmp8naa4l97/spack/lib/spack/spack/url.py
  isort checks were clean
==> Running mypy checks
  Success: no issues found in 508 source files
  mypy checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. I've updated the branch with isort fixes.

@vsoch

vsoch commented Jul 28, 2021

Copy link
Copy Markdown
Owner Author

@spackbot fix style

@spack-bot-develop

Copy link
Copy Markdown

Let me see if I can fix that for you! This might take a moment...

@vsoch

vsoch commented Jul 28, 2021

Copy link
Copy Markdown
Owner Author

@spackbot fix style

1 similar comment
@vsoch

vsoch commented Jul 28, 2021

Copy link
Copy Markdown
Owner Author

@spackbot fix style

@spack-bot-develop

Copy link
Copy Markdown

Let me see if I can fix that for you! This might take a moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant