[Minor Fix] Remove unused code in benchmark_prefix_caching.py#3171
Merged
zhuohan123 merged 1 commit intovllm-project:mainfrom Mar 4, 2024
gty111:main
Merged
[Minor Fix] Remove unused code in benchmark_prefix_caching.py#3171zhuohan123 merged 1 commit intovllm-project:mainfrom gty111:main
zhuohan123 merged 1 commit intovllm-project:mainfrom
gty111:main
Conversation
dtransposed
pushed a commit
to afeldman-nm/vllm
that referenced
this pull request
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
prefix_posis not an argument inLLM.generateat present, we should remove it in thebenchmark_prefix_caching.py. This may confuse some people who are unfamilar with prefix caching.#3158
cc @zhuohan123