-
Notifications
You must be signed in to change notification settings - Fork 599
feat: support access iframe #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@fatelei is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestions:
- getLocator method uses this.getPage() instead of this.getFrame(), breaking iframe support for regular selectors while refs work correctly
- handleScreenshot bypasses browser.getLocator() and uses page.locator() directly, losing iframe context and ref support
- handleSetValue and handleDispatch use page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
- handleBoundingBox uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleInnerText and handleInnerHtml use page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleCount uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe and ref support
- handleHighlight uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe support and ref support
- handleContent uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleClear uses page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
- handleSelectAll uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleScrollIntoView uses page.locator() directly instead of browser.getLocator(), bypassing ref support
- handleMultiSelect uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleScroll uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe support and ref support
- handleWheel uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
- handleInnerHtml and handleInnerText use page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref resolution
- handleNth function bypasses iframe and ref support by using page.locator() directly instead of browser.getLocator()
- handleDispatch uses page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestions:
- handleWait uses page.waitForSelector() directly instead of browser.getLocator().waitFor(), breaking consistency with other handlers and losing support for ref-based selectors and iframe context.
- handlePress uses page.press() directly instead of browser.getLocator() when a selector is provided, breaking support for iframe context and ref-based selectors
- handleTap uses page.tap() directly instead of browser.getLocator(), missing support for iframe context and ref-based selectors
fix #50