Skip to content

Conversation

@fatelei
Copy link

@fatelei fatelei commented Jan 21, 2026

fix #50

getFrame(): Frame {
    if (this.activeFrame) {
      return this.activeFrame;  // iframe
    }
    return this.getPage().mainFrame();
  }
browser.getLocator(selector) → getFrame() → activeFrame || mainFrame

@vercel
Copy link
Contributor

vercel bot commented Jan 21, 2026

@fatelei is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestions:

  1. getLocator method uses this.getPage() instead of this.getFrame(), breaking iframe support for regular selectors while refs work correctly
  1. handleScreenshot bypasses browser.getLocator() and uses page.locator() directly, losing iframe context and ref support
  1. handleSetValue and handleDispatch use page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
  1. handleBoundingBox uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleInnerText and handleInnerHtml use page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleCount uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleHighlight uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe support and ref support
  1. handleContent uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleClear uses page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
  1. handleSelectAll uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleScrollIntoView uses page.locator() directly instead of browser.getLocator(), bypassing ref support
  1. handleMultiSelect uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleScroll uses page.locator(command.selector) directly instead of browser.getLocator(), bypassing iframe support and ref support
  1. handleWheel uses page.locator() directly instead of browser.getLocator(), bypassing iframe and ref support
  1. handleInnerHtml and handleInnerText use page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref resolution
  1. handleNth function bypasses iframe and ref support by using page.locator() directly instead of browser.getLocator()
  1. handleDispatch uses page.locator() directly instead of browser.getLocator(), bypassing iframe support and ref support
Fix on Vercel

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestions:

  1. handleWait uses page.waitForSelector() directly instead of browser.getLocator().waitFor(), breaking consistency with other handlers and losing support for ref-based selectors and iframe context.
  1. handlePress uses page.press() directly instead of browser.getLocator() when a selector is provided, breaking support for iframe context and ref-based selectors
  1. handleTap uses page.tap() directly instead of browser.getLocator(), missing support for iframe context and ref-based selectors
Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to access iframe

1 participant