-
Notifications
You must be signed in to change notification settings - Fork 64
-name / should match /// #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 87.46% 87.51% +0.05%
==========================================
Files 31 31
Lines 6692 6704 +12
Branches 299 300 +1
==========================================
+ Hits 5853 5867 +14
+ Misses 627 626 -1
+ Partials 212 211 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please add a test to make sure we don't regress? Thanks |
Of course! |
|
@sylvestre Added the new test, can you review it? Thanks in advance. |
|
Hello, based on the Action logs, this RP seems to have caused a Windows test failure. Could you take a look? |
|
please also add a test in tests/find_cmd_tests.rs |
|
@sylvestre and @hanbings Could you review the tests? Thanks for the help and guidance of both. :) |
|
Thanks! |
Hi, I did some tests and the problem in #24 is because when we pass the './target/debug/find /// -maxdepth 0 -name /' it returns false.
I put an early return as an alternative solution, but I don't know if it's a good solution.