Fix compat tests not using the latest workflow #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, artifacts are only downloaded from the latest successful workflow, meaning that, if the compat tests regressed, then it is impossible to compare against the new current state. This isn't a perfect solution, but I believe it should by far be "good enough" for these purposes. Signed-off-by: Ryan Gonzalez <[email protected]>
Merged
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 52.58% 52.77% +0.19%
==========================================
Files 23 23
Lines 4650 4650
Branches 1529 1528 -1
==========================================
+ Hits 2445 2454 +9
Misses 1660 1660
+ Partials 545 536 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, artifacts are only downloaded from the latest successful
workflow, meaning that, if the compat tests regressed, then it is
impossible to compare against the new current state. This isn't a
perfect solution, but I believe it should by far be "good enough" for
these purposes.
Signed-off-by: Ryan Gonzalez [email protected]