Add shares: slashes are not allowed in share name #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unrelated but just a thought. Since shares are auto created when a new directory is added to /mnt/user; What happens a user creates a directory with a slash? |
Contributor
Can't create a directory with a forward-slash because that's a separator. A directory containing a back-slash or only a back-slash is valid, however it's not valid as a component of a file name on FAT32 which is where the same-named cfg file is created/looked for. This is the actual bug. |
Contributor
|
There are other places in webGUI that need this 'fix'. |
Contributor
|
Nice work! thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.