Skip to content

Conversation

@ultimatecoder
Copy link
Owner

  • Description: I am trying to remove my writing block by writing this is post after almost 8 months. Please try to review below points:

    • English (Grammer, Spellings)
    • Sentence formation. The flow of the sentence
    • Examples I have given are appropriate
  • How to review?
    Directly write your commentes at this PR. If you don't use Github, please ping me back or mail at jaysinhp at gmail dot com.

  • What you will get in return?
    I lot of love from my side, and I will give you credits at this post.

Note: For suggestions on further reasons regarding the behaviour of the function slice, I request to drop a mail at jaysinhp at gmail com or Tweet me at [@jaysinhp][https://twitter.com/jaysinhp] and wait until I initially publish this post.

Copy link

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a few comments, I hope they're helpful! (feel free to ping me here or in #python-offtopic if you ant any help with understanding any of it!) Friend has just reminded me I need to run out ^_^


![Title Image](/assets/images/python_slice_function/title_image.jpg)

Last Friday, I was sitting at one of the good coffee shop of Bangalore with my

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/at/in/

I'd probably also say "one of my friends", which seems more natural to me.


Last Friday, I was sitting at one of the good coffee shop of Bangalore with my
friend. Coffee and discussion is the best combination to release stress. It was
looking like a perfect Friday eve, until my friend stroke with an idea of asking

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friday evening, do you mean? (Friday eve would be the day before Friday, and mostly an archaic term at this point.)

Last Friday, I was sitting at one of the good coffee shop of Bangalore with my
friend. Coffee and discussion is the best combination to release stress. It was
looking like a perfect Friday eve, until my friend stroke with an idea of asking
me a question. Suddenly He said, "What if I ask you one quiz question based on

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/He/he/

friend. Coffee and discussion is the best combination to release stress. It was
looking like a perfect Friday eve, until my friend stroke with an idea of asking
me a question. Suddenly He said, "What if I ask you one quiz question based on
Python?". "Aha! What is the level of difficulty?" I confusingly requestioned.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention in English is each change of speaker gets a new paragraph.

looking like a perfect Friday eve, until my friend stroke with an idea of asking
me a question. Suddenly He said, "What if I ask you one quiz question based on
Python?". "Aha! What is the level of difficulty?" I confusingly requestioned.
Here he played the trick. He said, "It is a bit difficult, but not that much

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "much" there I don't think makes sense. Maybe "not that difficult" or "not very difficult" or "not too difficult"?

@gsnedders
Copy link

(Also, honestly, don't feel any need to credit me!)

@ultimatecoder ultimatecoder merged commit 7f70007 into master Oct 3, 2018
@ultimatecoder ultimatecoder deleted the master-slice-in-python branch January 8, 2019 07:10
@ultimatecoder ultimatecoder restored the master-slice-in-python branch January 8, 2019 07:10
@ultimatecoder ultimatecoder deleted the master-slice-in-python branch January 8, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants