-
Notifications
You must be signed in to change notification settings - Fork 17
♻️ Refactor tf averaged turn geometry #3885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
==========================================
- Coverage 46.39% 46.10% -0.29%
==========================================
Files 123 123
Lines 28167 28671 +504
==========================================
+ Hits 13067 13220 +153
- Misses 15100 15451 +351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
559fe30 to
785e3f2
Compare
timothy-nunn
approved these changes
Oct 13, 2025
…oss multiple files to enhance clarity and consistency in the codebase.
…ce_general_input' for improved clarity and consistency across the codebase.
… for improved clarity and consistency across the codebase.
… variable handling and clarity
…hance input validation
fd3f4d1 to
f9647e2
Compare
timothy-nunn
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the naming conventions for several variables related to toroidal field (TF) coil turn and cable dimensions throughout the codebase and documentation. The main goal is to improve clarity and consistency by replacing older variable names (
t_turn_tf,t_cable_tf, etc.) with new, more descriptive ones (dx_tf_turn_general,dx_tf_turn_cable_space_general, etc.). The changes affect documentation, code, input handling, and output files.🔄 Renames
t_turn_tf_is_input->i_dx_tf_turn_general_inputt_turn_tf->dx_tf_turn_generalt_cable_tf_is_input->i_dx_tf_turn_cable_space_generalt_cable_tf->dx_tf_turn_cable_space_generalThere is still some underlying functionality used for CORC cables that I will refactor in another PR
Checklist
I confirm that I have completed the following checks: