Skip to content

Conversation

@timothy-nunn
Copy link
Collaborator

@timothy-nunn timothy-nunn commented Sep 23, 2025

--full-output now works on evaluation input files e.g. large_tokamak_eval.MFILE.DATSUMMARY.pdf

Here I have also fixed some strings not wrapping after 60 characters and interesting plots on the first page. Some information about the evaluation runs was also wrong because it is not present in the MFile and was returning a default 0.

I have confirmed that the large tokamak still runs and produces an appropriate output: large_tokamak.MFILE.DATSUMMARY.pdf

@timothy-nunn timothy-nunn linked an issue Sep 23, 2025 that may be closed by this pull request
@timothy-nunn timothy-nunn self-assigned this Sep 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.22%. Comparing base (58b2c96) to head (c3ad5b9).

Files with missing lines Patch % Lines
process/io/plot_proc.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3867      +/-   ##
==========================================
- Coverage   46.22%   46.22%   -0.01%     
==========================================
  Files         123      123              
  Lines       28564    28569       +5     
==========================================
+ Hits        13203    13205       +2     
- Misses      15361    15364       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn requested review from chris-ashe and removed request for jonmaddock September 23, 2025 13:10
@timothy-nunn timothy-nunn changed the title Output run type for evaluation mfiles instead of figure of merit Fix full-output for evaluation MFiles Oct 3, 2025
@timothy-nunn timothy-nunn force-pushed the 3843-bug-running---full-output-on-an-evaluation-mode-indat-fails branch from 788cd2a to 8844136 Compare October 7, 2025 15:18
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cheeked the provided output pdf. Why is the solver iterations still a float?

@timothy-nunn timothy-nunn force-pushed the 3843-bug-running---full-output-on-an-evaluation-mode-indat-fails branch from 8844136 to c3ad5b9 Compare October 30, 2025 16:21
@timothy-nunn
Copy link
Collaborator Author

Just cheeked the provided output pdf. Why is the solver iterations still a float?

Fixed, here are the new PDFs
large_tokamak_eval.MFILE.DATSUMMARY.pdf
large_tokamak.MFILE.DATSUMMARY.pdf

@timothy-nunn timothy-nunn merged commit 87edae3 into main Nov 4, 2025
26 of 27 checks passed
@timothy-nunn timothy-nunn deleted the 3843-bug-running---full-output-on-an-evaluation-mode-indat-fails branch November 4, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Running --full-output on an evaluation-mode IN.DAT fails

4 participants