Skip to content

Conversation

@timothy-nunn
Copy link
Collaborator

Thanks @nickodell for this great suggestion. This stops numba from compiling the linalg.solve against SciPy's solvers and uses numpy's linear algebra in normal (non-Numba) mode. I also took this opportunity to remove the asfortranarray because that is not necessary (and possibly has never been)

@timothy-nunn timothy-nunn linked an issue Sep 19, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.06%. Comparing base (aff2888) to head (62487ff).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
process/tf_coil.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3856      +/-   ##
==========================================
- Coverage   46.67%   43.06%   -3.62%     
==========================================
  Files         122      123       +1     
  Lines       27806    33237    +5431     
==========================================
+ Hits        12978    14312    +1334     
- Misses      14828    18925    +4097     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Sep 19, 2025
@timothy-nunn timothy-nunn mentioned this pull request Sep 23, 2025
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, but needs a comment about why this is required.

@timothy-nunn timothy-nunn force-pushed the linalg-solve-in-obj-mode branch from 5ce880e to 62487ff Compare September 25, 2025 12:48
@timothy-nunn timothy-nunn merged commit b80c5b4 into main Sep 25, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the linalg-solve-in-obj-mode branch September 25, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_plane_stress failures on certain OS

5 participants