Skip to content

Conversation

@jonmaddock
Copy link
Contributor

@jonmaddock jonmaddock commented Mar 11, 2025

Ensure pdivt is kept positive continuously.

pdivt with continuous kludge:

kludged_pdivt

And again, but with finer sampling resolution to show continuous nature:

kludged_pdivt_zoom

@jonmaddock jonmaddock linked an issue Mar 11, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.21%. Comparing base (0ace3f9) to head (6262e53).

Files with missing lines Patch % Lines
process/physics.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3579   +/-   ##
=======================================
  Coverage   31.21%   31.21%           
=======================================
  Files          83       83           
  Lines       19938    19938           
=======================================
  Hits         6223     6223           
  Misses      13715    13715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonmaddock jonmaddock requested a review from mkovari March 14, 2025 10:44
@jonmaddock jonmaddock self-assigned this Mar 14, 2025
Copy link
Collaborator

@mkovari mkovari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am bit concerned that you are redefining pdivt. If this code is ever run again then this change could be made repeatedly. Is there any chance of this happening?

@jonmaddock
Copy link
Contributor Author

jonmaddock commented Mar 17, 2025

I am bit concerned that you are redefining pdivt. If this code is ever run again then this change could be made repeatedly. Is there any chance of this happening?

I'm not quite sure what you mean; if you mean non-idempotence, then this isn't an issue: each time the model is called (with the same values) pdivt is calculated from other values (in the lines immediately above this change) and this kludge is applied. The same value of pdivt results each time. Does that answer your question?

@jonmaddock jonmaddock requested a review from mkovari March 17, 2025 10:41
@jonmaddock jonmaddock merged commit 9175fe1 into main Mar 17, 2025
18 checks passed
@jonmaddock jonmaddock deleted the 3578-continuous-kludge-to-keep-pdivt-0 branch March 17, 2025 11:46
@clmould clmould mentioned this pull request Jun 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Continuous kludge to keep pdivt > 0

4 participants