-
Notifications
You must be signed in to change notification settings - Fork 17
Removed tresca from some variable names, swapped for s_shear #3568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3568 +/- ##
=======================================
Coverage 31.21% 31.21%
=======================================
Files 83 83
Lines 19938 19938
=======================================
Hits 6223 6223
Misses 13715 13715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ym1906
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This reverts commit 5e0e1f6.
ca07aa9 to
24aba4e
Compare
chris-ashe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with name changes
|
@timothy-nunn Could you give final review and merge please. |
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that these changes are added to obsolete vars and with the regression failures. However, the pre-commit job is failing, please fix it.
|
Thanks Tim! |
Description
I have changed the following variable names related to shear stress