Skip to content

Conversation

@ym1906
Copy link
Collaborator

@ym1906 ym1906 commented Mar 5, 2025

Description

I have changed the following variable names related to shear stress

    "s_tresca_oh" -> "s_shear_cs_peak",
    "sig_tf_tresca_max" -> "s_shear_tf_peak",
    "s_tresca_cond_cear" -> "s_shear_cea_tf_cond",
    "sig_tf_tresca" -> "s_shear_tf", 

@ym1906 ym1906 linked an issue Mar 5, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 31.21%. Comparing base (60635ad) to head (f708e94).

Files with missing lines Patch % Lines
process/sctfcoil.py 0.00% 13 Missing ⚠️
process/pfcoil.py 0.00% 2 Missing ⚠️
process/io/plot_proc.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3568   +/-   ##
=======================================
  Coverage   31.21%   31.21%           
=======================================
  Files          83       83           
  Lines       19938    19938           
=======================================
  Hits         6223     6223           
  Misses      13715    13715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn requested a review from chris-ashe March 5, 2025 16:20
Copy link
Collaborator Author

@ym1906 ym1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ym1906 ym1906 self-assigned this Mar 6, 2025
@ym1906 ym1906 force-pushed the 990-tresca-stress-definition branch from ca07aa9 to 24aba4e Compare March 6, 2025 16:31
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with name changes

@ym1906
Copy link
Collaborator Author

ym1906 commented Mar 7, 2025

@timothy-nunn Could you give final review and merge please.

@ym1906 ym1906 requested a review from timothy-nunn March 7, 2025 14:42
Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that these changes are added to obsolete vars and with the regression failures. However, the pre-commit job is failing, please fix it.

@ym1906 ym1906 requested a review from timothy-nunn March 10, 2025 09:19
@timothy-nunn timothy-nunn merged commit 495bf59 into main Mar 10, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the 990-tresca-stress-definition branch March 10, 2025 09:55
@ym1906
Copy link
Collaborator Author

ym1906 commented Mar 10, 2025

Thanks Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TRESCA stress definition

5 participants