Skip to content

VV stress under quench model review #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timothy-nunn merged 14 commits into from
Mar 20, 2025
Merged

VV stress under quench model review #3366

timothy-nunn merged 14 commits into from
Mar 20, 2025

Conversation

@ajpearcey
Copy link
Collaborator

@ajpearcey ajpearcey commented Oct 30, 2024

closes #3354

@ajpearcey ajpearcey changed the title VV stress under quench model review WIP: VV stress under quench model review Oct 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.70%. Comparing base (32083c7) to head (a7819ae).

Files with missing lines Patch % Lines
process/hcpb.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
+ Coverage   31.59%   31.70%   +0.11%     
==========================================
  Files          84       84              
  Lines       20112    20146      +34     
==========================================
+ Hits         6355     6388      +33     
- Misses      13757    13758       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ajpearcey ajpearcey changed the title WIP: VV stress under quench model review VV stress under quench model review Nov 27, 2024
@ajpearcey ajpearcey changed the title VV stress under quench model review WIP: VV stress under quench model review Jan 8, 2025
@ajpearcey ajpearcey force-pushed the issue-3354-vv_stress_quench branch from 464c37e to c802ec6 Compare January 28, 2025 11:03
@ajpearcey ajpearcey mentioned this pull request Feb 20, 2025
Closed
@ajpearcey ajpearcey force-pushed the issue-3354-vv_stress_quench branch 2 times, most recently from e2c0cc2 to d9a03e6 Compare February 27, 2025 16:27
@ajpearcey ajpearcey changed the title WIP: VV stress under quench model review VV stress under quench model review Feb 28, 2025
@ajpearcey ajpearcey requested a review from chris-ashe March 3, 2025 11:04
chris-ashe
chris-ashe requested changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small corrections first

@ajpearcey ajpearcey force-pushed the issue-3354-vv_stress_quench branch from 331374e to b7bd97c Compare March 12, 2025 14:11
@ajpearcey ajpearcey requested a review from chris-ashe March 12, 2025 15:38
chris-ashe
chris-ashe requested changes Mar 13, 2025
View reviewed changes
@ajpearcey ajpearcey requested a review from chris-ashe March 13, 2025 16:35
@ajpearcey ajpearcey force-pushed the issue-3354-vv_stress_quench branch from 0aded77 to 55792f4 Compare March 13, 2025 17:09
chris-ashe
chris-ashe approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@ajpearcey ajpearcey force-pushed the issue-3354-vv_stress_quench branch from 55792f4 to a7819ae Compare March 20, 2025 13:47
@timothy-nunn timothy-nunn merged commit 3748c5b into main Mar 20, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the issue-3354-vv_stress_quench branch March 20, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-ashe chris-ashe chris-ashe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VV stress under quench model review

5 participants

@ajpearcey @codecov-commenter @chris-ashe @timothy-nunn