Skip to content

Conversation

@j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Oct 24, 2024

Description

Fixes divlife_cal not being set, causing coe to be NaN.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Oct 24, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (f6af42a) to head (19e5e63).

Files with missing lines Patch % Lines
process/costs.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   27.22%   27.21%   -0.01%     
==========================================
  Files          76       76              
  Lines       17758    17762       +4     
==========================================
  Hits         4834     4834              
- Misses      12924    12928       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothy-nunn timothy-nunn merged commit a6008b0 into main Oct 24, 2024
@timothy-nunn timothy-nunn deleted the 3358-fix-divlife_cal-breaking-ci branch October 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix divlife_cal breaking CI

4 participants