Skip to content

Conversation

@ym1906
Copy link
Collaborator

@ym1906 ym1906 commented Sep 9, 2024

…c one

Description

Updated bootsrap_sauter to use existing plasma profile instead of recalculating a new, slightly different one.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-requested a review September 10, 2024 07:46
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes no remove the need to call the plasma_profiles class to run methods internally. The value is now taken explicitly from the object properties. The default profile size of 500 now causes changes to the unit test as the original was 200, this has been updated

@chris-ashe chris-ashe merged commit 48c7731 into main Sep 10, 2024
@chris-ashe chris-ashe deleted the 1821-pythonise-bootstrap_fraction_sauter-function-in-physicsf90-and-integrate-refactored-plasmaprofiles-with-it branch September 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pythonise bootstrap_fraction_sauter() function in physics.f90 and integrate refactored PlasmaProfiles with it

3 participants