3243 remove gamfun and replace it with the analytical solution from scipy #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a instead of maths_library.gamfun
…ecial.gamma instead
j-a-foster
reviewed
Jul 4, 2024
Collaborator
j-a-foster
left a comment
There was a problem hiding this comment.
All looks good to me. I'm assuming where you've removed maths_library that it's only imported to call gamfun?
…scipy.special.gamma instead" This reverts commit 34219f9.
Collaborator
Author
|
@j-a-foster Have reverted the commit as it was causing problems with |
timothy-nunn
requested changes
Jul 5, 2024
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
timothy-nunn
requested changes
Jul 8, 2024
timothy-nunn
approved these changes
Jul 8, 2024
chris-ashe
added a commit
that referenced
this pull request
Jul 8, 2024
…cipy (#3244) * Refactor plasma_profiles.py and profiles.py to use scipy.special.gamma instead of maths_library.gamfun * Refactor maths_library.f90 to remove gamfun function and use scipy.special.gamma instead * Black format * Update unit tests * Revert "Refactor maths_library.f90 to remove gamfun function and use scipy.special.gamma instead" This reverts commit 34219f9. * Update process/profiles.py Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com> * chore: Update scipy import in profiles.py --------- Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of
gamfun()frommaths_library.f90withinplasma_profiles.pyfor the temperature profile has been removed and replaced withscipy.special.gammaChecklist
I confirm that I have completed the following checks: