Skip to content

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Mar 19, 2024

Description

An update to #321 after merge.
q is now be in the input file as just q95

Using q95 makes it more explicit than just using q for the edge and the first assignment in physics() was to set q95 = q

 physics_variables.q95 = physics_variables.q

        # Calculate plasma composition
        # Issue #261 Remove old radiation model (imprad_model=0)
        self.plasma_composition()

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from timothy-nunn March 19, 2024 10:15
@chris-ashe chris-ashe self-assigned this Mar 19, 2024
@chris-ashe chris-ashe changed the title update q -> q95 WIP: update q -> q95 Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.55%. Comparing base (d2883c4) to head (af97a73).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3108   +/-   ##
=======================================
  Coverage   31.54%   31.55%           
=======================================
  Files          82       82           
  Lines       19567    19565    -2     
=======================================
  Hits         6173     6173           
+ Misses      13394    13392    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chris-ashe chris-ashe force-pushed the update-q_definition branch 3 times, most recently from bf30780 to 3b709b6 Compare February 18, 2025 09:25
@chris-ashe chris-ashe changed the title WIP: update q -> q95 Replace q with just q95 Feb 18, 2025
Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor style points

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timothy-nunn timothy-nunn merged commit 7db8627 into main Feb 18, 2025
18 checks passed
@chris-ashe chris-ashe deleted the update-q_definition branch February 18, 2025 13:31
ajpearcey pushed a commit that referenced this pull request Feb 26, 2025
* update q -> q95

* Rename 'q' to 'q95' in multiple data files for clarity and consistency

* Fix typo in safety factor description for q95 in input.f90

* 🔥 Remove q and replace with just q95

* ✅ Update q in tests

* lint

* add to obsolete variables

* Refactor iotabar assignment for clarity in stellarator scaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants