-
Notifications
You must be signed in to change notification settings - Fork 17
Replace q with just q95
#3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace q with just q95
#3108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
=======================================
Coverage 31.54% 31.55%
=======================================
Files 82 82
Lines 19567 19565 -2
=======================================
Hits 6173 6173
+ Misses 13394 13392 -2 ☔ View full report in Codecov by Sentry. |
bf30780 to
3b709b6
Compare
234bd3f to
83bc75f
Compare
006b20a to
91a2c7e
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor style points
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
528cc6f to
af97a73
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* update q -> q95 * Rename 'q' to 'q95' in multiple data files for clarity and consistency * Fix typo in safety factor description for q95 in input.f90 * 🔥 Remove q and replace with just q95 * ✅ Update q in tests * lint * add to obsolete variables * Refactor iotabar assignment for clarity in stellarator scaling
Description
An update to #321 after merge.
qis now be in the input file as justq95Using
q95makes it more explicit than just usingqfor the edge and the first assignment inphysics()was to setq95 = qChecklist
I confirm that I have completed the following checks: