3014 convert sig tfdat statements to json #3016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmaddock
requested changes
Dec 15, 2023
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
I'm fine with these changes, but could you organise the commits a bit better? The multiple small commits to change .DATs to .jsons could be squashed together. Could you also remove the churn with the black formatting of sctfcoil.py by squashing/fixing up those two commits together? Then it can go right in. Thanks!
remove .dat open statement in init_module gitignore doc changes
black changes
d44f7ec to
8e99848
Compare
jonmaddock
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sig_tf.dat was still being created and mentioned even though it has been replaced with a json type file.
The .dat creation has been removed and some remnants mentioning the .dat have been appropriately changed to json
@clmould This should fix it
Checklist
I confirm that I have completed the following checks: