Skip to content

Corrected number of days in year in annual cost calculation #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timothy-nunn merged 1 commit into from
Dec 5, 2023
Merged

Corrected number of days in year in annual cost calculation #3010

timothy-nunn merged 1 commit into from
Dec 5, 2023

Conversation

@j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Dec 5, 2023 •
edited
Loading

Description

This corrects an annual cost calculation in costs_2015.py where the number of days in a year was incorrectly given as 265.25. This has been corrected to 365.25.

Closes #2949

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments. (N/A)
  • I have added new tests where appropriate for the changes I have made. (N/A)
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments. (N/A)
  • If I have made documentation changes, I have checked they render correctly. (N/A)
  • I have added documentation for my change, if appropriate. (N/A)

@j-a-foster j-a-foster linked an issue Dec 5, 2023 that may be closed by this pull request
Calculation of annual_electrical_output in costs_2015.py #2949
Closed
@chris-ashe chris-ashe self-assigned this Dec 5, 2023
@chris-ashe
Copy link
Collaborator

chris-ashe commented Dec 5, 2023

@timothy-nunn This has been checked. Please approve ASAP

@chris-ashe chris-ashe added the Cost model Relating to cost models label Dec 5, 2023
@timothy-nunn timothy-nunn merged commit f145d83 into main Dec 5, 2023
@timothy-nunn timothy-nunn deleted the 2949-calculation-of-annual_electrical_output-in-costs_2015py branch December 5, 2023 16:02
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@j-a-foster @chris-ashe
Corrected number of days in year in annual cost calculation (#3010)
74a72ab
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@j-a-foster @chris-ashe
Corrected number of days in year in annual cost calculation (#3010)
5792eb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

Assignees

@chris-ashe chris-ashe

@j-a-foster j-a-foster

Labels

Cost model Relating to cost models

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calculation of annual_electrical_output in costs_2015.py

4 participants

@j-a-foster @chris-ashe @timothy-nunn