Skip to content

Conversation

@timothy-nunn
Copy link
Collaborator

@timothy-nunn timothy-nunn commented Sep 6, 2023

I think having issue templates will be a good QOL change for this repository pre-open-source. These issue templates are mostly taken from bluemira.

We should also add a PR template that reflects the proposed format of #2892.

@timothy-nunn timothy-nunn requested review from jonmaddock and removed request for jonmaddock September 6, 2023 16:21
@timothy-nunn timothy-nunn marked this pull request as draft September 6, 2023 16:25
@timothy-nunn timothy-nunn changed the title Add issue templates Add issue and PR templates Sep 7, 2023
@timothy-nunn timothy-nunn marked this pull request as ready for review September 7, 2023 10:17
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look really good Tim. I've got a few questions on the pull request template, which I feel is a bit much, but maybe this is actually useful/standard and we should be doing it. Let me know your comments.

Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonmaddock jonmaddock merged commit 25dbe7a into main Sep 12, 2023
@jonmaddock jonmaddock deleted the timothy-nunn/issue-templates branch September 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants