Upgrade default GHC to 9.2.8

[avdv]

depends on #1988

[avdv]

Note, this is used here

rules_haskell/rules_haskell_tests/tests/repl-targets/hs_lib_repl_test/WORKSPACE

Lines 132 to 136 in 8271ec2

	setup_deps = {
	"alex": ["@stackage//:Cabal"],
	"c2hs": ["@stackage//:Cabal"],
	"happy": ["@stackage//:Cabal"],
	},

What this means is that it uses the Cabal from the git commit given in the stackage yaml config.

So instead of adding a http_archive for Cabal like this

rules_haskell/extensions/rules_haskell_dependencies.bzl

Lines 28 to 43 in 8271ec2

	http_archive(
	name = "Cabal",
	build_file_content = """
	load("@rules_haskell//haskell:cabal.bzl", "haskell_cabal_library")
	haskell_cabal_library(
	name = "Cabal",
	srcs = glob(["Cabal/**"]),
	verbose = False,
	version = "3.8.1.0",
	visibility = ["//visibility:public"],
	)
	""",
	sha256 = "b697b558558f351d2704e520e7dcb1f300cd77fea5677d4b2ee71d0b965a4fe9",
	strip_prefix = "cabal-ghc-9.4-paths-module-relocatable",
	urls = ["https://github.com/tweag/cabal/archive/refs/heads/ghc-9.4-paths-module-relocatable.zip"],
	)

and then using @Cabal//:Cabal in setup_deps we might just use the cabal from the stackage snapshot directly as above. This would probably mean that every stack_snapshot would build it's own Cabal package instead of re-using the one from the Cabal repo. WDYT?

[aherrmann]

This would probably mean that every stack_snapshot would build it's own Cabal package instead of re-using the one from the Cabal repo. WDYT?

What do you mean by every stack_snapshot? It would only affect those that use this custom snapshot, correct? Or do you mean that this sets it as the default, and users would have to opt out by explicitly setting their own snapshot? I think in this case this is okay since it fixes a critical bug, i.e. without this most builds just won't work at all. And users can opt out with an explicit snapshot.

[avdv]

As discussed, I'll try to remove the redundant @Cabal repositories and use the Cabal from stackage directly.

[dpulls]

🎉 All dependencies have been resolved !

[aherrmann]

Thank you! LGTM, only a small comment.

[aherrmann]

This would probably mean that every stack_snapshot would build it's own Cabal package instead of re-using the one from the Cabal repo. WDYT?

What do you mean by every stack_snapshot? It would only affect those that use this custom snapshot, correct? Or do you mean that this sets it as the default, and users would have to opt out by explicitly setting their own snapshot? I think in this case this is okay since it fixes a critical bug, i.e. without this most builds just won't work at all. And users can opt out with an explicit snapshot.