Fix computation of transitive dependencies - #1669
Merged
Merged
Conversation
facundominguez
commented
Dec 21, 2021
|
|
||
| def _collect_narrowed_deps_module_files(ctx_label, per_module_transitive_files, dep): | ||
| direct_cross_library_deps = dep[HaskellModuleInfo].direct_cross_library_deps | ||
| transitive_cross_library_dep_labels = dep[HaskellModuleInfo].transitive_cross_library_dep_labels.to_list() |
Member
Author
There was a problem hiding this comment.
This flattening could be problematic because the depset could be large. I'm still thinking how to avoid it.
Member
Author
There was a problem hiding this comment.
I reverted this and created a better solution in af97995.
aherrmann
approved these changes
Dec 22, 2021
aherrmann
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you!
One small comment.
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important fix here is exposing interface files coming from transitive cross-library dependencies. Otherwise, the strengthened tests would fail.