Set the minimal requirement for Haddock and protobuf - #1108
Merged
Conversation
guibou
force-pushed
the
repro_1030
branch
2 times, most recently
from
September 22, 2019 13:49
5c41922 to
5445a22
Compare
guibou
marked this pull request as ready for review
September 22, 2019 14:19
mboes
reviewed
Sep 22, 2019
mboes
left a comment
Contributor
There was a problem hiding this comment.
I don't feel confident about this code change. @aherrmann I'm handing over the baton to you.
aherrmann
reviewed
Sep 27, 2019
| "HaskellLibraryInfo", | ||
| "HaskellProtobufInfo", | ||
| ) | ||
| load(":private/pkg_id.bzl", "pkg_id") |
Contributor
There was a problem hiding this comment.
Suggested change
| load(":private/pkg_id.bzl", "pkg_id") |
This looks unused.
|
|
||
| haddock_info = HaddockInfo( | ||
| package_id = None, | ||
| package_id = package_id, |
Contributor
There was a problem hiding this comment.
Is it necessary to duplicate package_id in HaddockInfo, or would the field in HaskellLibraryInfo suffice? In other words, do we have targets that provide HaddockInfo but not HaskellLibraryInfo?
Contributor
There was a problem hiding this comment.
I don't believe we need this duplication.
Contributor
Author
There was a problem hiding this comment.
I do agree with you. However I thank that's orthogonal to this pull request.
Contributor
There was a problem hiding this comment.
Fair enough. That can also be done in a separate PR.
aherrmann
approved these changes
Sep 30, 2019
- `//tests/haddock_protobuf:haddocks_b` fails - `//tests/haddock_protobuf:haddocks_a` builds, but the haddock process does not see the documentation link for 'Proto.Tests.HaddockProtobuf.HelloWorld.Person'
`package_id` cannot be None, because it is used in the rest of the process. It is now set to the real name of this haskell package. The protobuf process does not generate haddock informations, as reported in #1030, leading to missing documentation link and build failures. `transitive_html` must contain a key with the current package_id. This is fixed to an empty list. This is a partial fix for #1030 because it fixs the build failure
jwiegley
force-pushed
the
repro_1030
branch
from
September 30, 2019 08:49
5445a22 to
1d7c5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step to fix #1030. It comes with tests:
//tests/haddock_protobuf:haddocks_bwas failing, it is now fixed//tests/haddock_protobuf:haddocks_abuilds, but the haddock processdoes not see the documentation link for
Proto.Tests.HaddockProtobuf.HelloWorld.Person. Not fixed yet.