[AMD][BACKEND] Include BufferLoadToLocal in UpdateAsyncWaitCount computations
#8621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
approved these changes
Nov 3, 2025
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
…computations (triton-lang#8621) triton-lang#8575 moved `UpdateAsyncWaitCount` from `TTIR->TTGIR` (before converting to buffer ops) to `TTGIR->LLVM`. This means we now have to include `amdgpu.buffer_load_to_local` when counting outstanding async instructions. This change is also required for Gluon where we directly emit buffer ops. Ignoring them causes a performance regressions because we are emitting conservative waits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8575 moved
UpdateAsyncWaitCountfromTTIR->TTGIR(before converting to buffer ops) toTTGIR->LLVM. This means we now have to includeamdgpu.buffer_load_to_localwhen counting outstanding async instructions. This change is also required for Gluon where we directly emit buffer ops.Ignoring them causes a performance regressions because we are emitting conservative waits.