[BACKEND] Generalise maybeDeduplicate to all layouts #8492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
include/triton/Conversion/TritonGPUToLLVM/ElementwiseOpToLLVMBase.h
Outdated
Show resolved
Hide resolved
We had a subtle asymmetry here that was producing different PTX for the same layout.
masahi
pushed a commit
to masahi/triton
that referenced
this pull request
Oct 24, 2025
We had a subtle asymmetry here that was producing different PTX for the same layout. We now generalise this pass to work with any layout and we drop a few restrictions the previous pass had.
lezcano
added a commit
that referenced
this pull request
Oct 29, 2025
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
We had a subtle asymmetry here that was producing different PTX for the same layout. We now generalise this pass to work with any layout and we drop a few restrictions the previous pass had.
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
…nerically (triton-lang#8421) (triton-lang#8495) This PR relands triton-lang#8386. It depends on triton-lang#8492 to avoid regressing in some workloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a subtle asymmetry here that was producing different PTX for the
same layout. We now generalise this pass to work with any layout and we drop
a few restrictions the previous pass had.