[BACKEND] Prevent combinatory explosion when checking tmem_load uses #8477
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| llvm::DenseSet<std::pair<Value, Attribute>> visited; | ||
| while (!uses.empty()) { | ||
| auto [v, encoding] = uses.pop_back_val(); | ||
| if (!visited.insert({v, encoding}).second) |
There was a problem hiding this comment.
Include headers for new DenseSet usage
The new llvm::DenseSet<std::pair<Value, Attribute>> visited relies on both the llvm::DenseSet declaration and DenseMapInfo<Attribute>. This file does not include either llvm/ADT/DenseSet.h or mlir/Support/LLVM.h, so the compilation unit will fail to build once this code is seen because DenseSet and DenseMapInfo<mlir::Attribute> are undefined here. Add the appropriate headers before using the set.
Useful? React with 👍 / 👎.
No description provided.