[AMD] Option to use custom scheduler in LLVM backend #8326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de08064 to
cfe234b
Compare
This PR: - generalize flags in translate_to_asm function, so now it accepts bool and string flags - introduces new case to HIPOptions.schedule_hint which enables iterative-ilp scheduler
c259e3e to
7c78175
Compare
antiagainst
requested changes
Nov 8, 2025
antiagainst
approved these changes
Nov 10, 2025
ThomasRaoux
reviewed
Nov 10, 2025
Comment on lines
+451
to
+455
| for hint in options.schedule_hint.split(","): | ||
| if hint == 'attention': | ||
| flags.append(('sink-insts-to-avoid-spills', True)) | ||
| if hint == 'memory-bound-attention': | ||
| flags.append(('amdgpu-sched-strategy', 'iterative-ilp')) |
Collaborator
There was a problem hiding this comment.
having llvm dynamic llvm flags will cause multi-threading problems and is going to be a serious problem in real life scenario.
I think we need a different solution here
Collaborator
There was a problem hiding this comment.
Ah good point; missed that part. Sorry about it. Yeah we can revert this and find a better way--maybe like using some attributes attached to llvm module or something. BTW, the whole schedule hint was meant to be experiemental--more a way to help making trying different LLVM features easier in workloads so we can better work them into LLVM properly.
Collaborator
There was a problem hiding this comment.
got it, it's probably fine as experimental but we have to be a bit careful as it breaks in a very subtle way. (usually cause non deterministic cache to be generated)
Attributes would be much better if it is possible
antiagainst
added a commit
that referenced
this pull request
Nov 10, 2025
Reverts #8326 given changing flags makes multi-threading difficult.
antiagainst
pushed a commit
that referenced
this pull request
Nov 15, 2025
This is thread safe implementation of #8326. This PR changed to use function attributes instead of global flags. It also deletes other existing global flag usage along the way.
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
…on-lang#8326) This PR: - generalize flags in translate_to_asm function, so now it accepts bool and string flags - introduces new case to HIPOptions.schedule_hint which enables iterative-ilp scheduler --------- Co-authored-by: Alexander Efimov <efimov.alexander@gmail.com>
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
…-lang#8685) Reverts triton-lang#8326 given changing flags makes multi-threading difficult.
tmoreau89
pushed a commit
to tmoreau89/triton
that referenced
this pull request
Dec 1, 2025
This is thread safe implementation of triton-lang#8326. This PR changed to use function attributes instead of global flags. It also deletes other existing global flag usage along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: