[AMD] Replace mfma select in LLVM conversion #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
approved these changes
Sep 30, 2025
Collaborator
antiagainst
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
auto-merge was automatically disabled
September 30, 2025 05:46
Head branch was pushed to by a user without write access
yangshuxin
pushed a commit
to yangshuxin/triton
that referenced
this pull request
Oct 3, 2025
Given we already encode the kDim in `instrShape`, we don't need to select again when lowering mfma, just directly get the instruction, when matching all parameters.
Jokeren
pushed a commit
that referenced
this pull request
Oct 10, 2025
Given we already encode the kDim in `instrShape`, we don't need to select again when lowering mfma, just directly get the instruction, when matching all parameters.
ita9naiwa
pushed a commit
to ita9naiwa/triton
that referenced
this pull request
Oct 12, 2025
Given we already encode the kDim in `instrShape`, we don't need to select again when lowering mfma, just directly get the instruction, when matching all parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we already encode the kDim in
instrShape, we don't need to select again when lowering mfma, just directly get the instruction, when matching all parameters.