[AMD] Use lld library API #7548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
reviewed
Jul 18, 2025
Collaborator
antiagainst
left a comment
There was a problem hiding this comment.
Nice!! Just a few nits.
antiagainst
approved these changes
Jul 18, 2025
antiagainst
pushed a commit
that referenced
this pull request
Jul 22, 2025
The PR #7548 requires the use of LLD as part of LLVM (as opposed to the system LDD), which causes the following error when - (1) ldd is not built, or - (2) the location of the `LLD_DIR` is not specified correctly: ``` CMake Error at third_party/amd/CMakeLists.txt:6 (find_package): Could not find a package configuration file provided by "LLD" with any of the following names: LLDConfig.cmake lld-config.cmake ``` To fix this issue, this PR made the following changes: - For (1), build lld in `scripts/build-llvm-project.sh`, which is invoked by `make dev-install-llvm`. The script was added in README in #6709, and building ldd was added in #6049. - For (2), make sure that `LLVM_BUILD_PATH` is an absolute path in Makefile, so `LLD_DIR` and `MLIR_DIR` are interpereted correctly. Otherwise CMake has hard time finding the relative location with CMakeLists.txt in a subdirectory. - Introduce `LLD_DIR` so we don't write `"${MLIR_DIR}/../lld"`.
ShawnZhong
reviewed
Jul 31, 2025
| @staticmethod | ||
| def path_to_rocm_lld(): | ||
| # Check env path for ld.lld | ||
| lld_env_path = knobs.amd.lld_path |
Contributor
There was a problem hiding this comment.
nit: this knob can now be removed
Line 446 in 98d23fe
antiagainst
pushed a commit
that referenced
this pull request
Jul 31, 2025
No longer used after #7548
stadlmax
pushed a commit
to stadlmax/triton
that referenced
this pull request
Aug 4, 2025
No longer used after triton-lang#7548
stadlmax
pushed a commit
to stadlmax/triton
that referenced
this pull request
Aug 4, 2025
No longer used after triton-lang#7548
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces shell out to ROCm's lld by directly calling the lld library API.
Fixes https://github.com/ROCm/triton-internal/issues/997