[Gluon] Implement broadcasting and expand_dims #7080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mogball
reviewed
Jun 6, 2025
| @gluon.jit | ||
| def broadcast_kernel(): | ||
| layout: ttgl.constexpr = ttgl.BlockedLayout([1, 1], [2, 16], [4, 1], [1, 0]) | ||
| a = ttgl.arange(0, 16, layout=ttgl.SliceLayout(0, layout))[None, :] |
Mogball
reviewed
Jun 6, 2025
Comment on lines
45
to
46
| assert isinstance(layout, SliceLayout) | ||
| assert layout.dim == axis |
Collaborator
There was a problem hiding this comment.
Do you mind adding some error messages here? In particular, the error message printing the invalid value I find is super helpful because often it's hard to tell by looking at the kernel code (it's like writing C++ but everything is auto)
5ef25d3 to
48fbbe9
Compare
16f7d0e to
4c836a3
Compare
4c836a3 to
02f3999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make life simple, this assumes that
expand_dims(x, dim)has aSliceLayoutwith matching dimension as the outermost layout.