Skip to content

Conversation

@peterbell10
Copy link
Contributor

@peterbell10 peterbell10 commented May 30, 2025

Commits in this PR

  1. [Gluon] Add mbarrier

    This implements:

    • ttgl.SwizzledSharedLayout
    • ttgl.nvidia.hopper.mbarrier.MBarrierLayout (convenience wrapper for SwizzledSharedLayout)
    • ttgl.nvidia.hopper.mbarrier.init
    • ttgl.nvidia.hopper.mbarrier.invalidate
    • ttgl.nvidia.hopper.mbarrier.expect
    • ttgl.nvidia.hopper.mbarrier.wait
    • ttgl.nvidia.hopper.mbarrier.arrive

    plus aliases in ttgl.nvidia.blackwell.mbarrier

    Note that I'm keeping this API functional to allow interpreting
    any shared allocation as an mbarrier. We can wrap with higher level
    APIs at a later date if desired.

  2. Add unsaved changes

PR chain

  1. 👉 [Gluon] Add mbarrier #6997 👈 YOU ARE HERE
  2. [Gluon] Add tcgen05_mma and fix non-initialized allocate_tensor_memory #6998

@peterbell10 peterbell10 requested a review from ptillet as a code owner May 30, 2025 13:19
This implements:
- `ttgl.SwizzledSharedLayout`
- `ttgl.nvidia.hopper.mbarrier.MBarrierLayout` (convenience wrapper for `SwizzledSharedLayout`)
- `ttgl.nvidia.hopper.mbarrier.init`
- `ttgl.nvidia.hopper.mbarrier.invalidate`
- `ttgl.nvidia.hopper.mbarrier.expect`
- `ttgl.nvidia.hopper.mbarrier.wait`
- `ttgl.nvidia.hopper.mbarrier.arrive`

plus aliases in `ttgl.nvidia.blackwell.mbarrier`

Note that I'm keeping this API functional to allow interpreting
any shared allocation as an mbarrier. We can wrap with higher level
APIs at a later date if desired.

git-pr-chain: gluon_add_mbarrier_9afe
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbell10 peterbell10 enabled auto-merge (squash) May 30, 2025 16:09
@peterbell10 peterbell10 merged commit 6aa49bb into main May 30, 2025
8 checks passed
@peterbell10 peterbell10 deleted the pb/pr-chain/gluon_add_mbarrier_9afe branch May 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants