Fix issue with minimum-perc skip message

[codegaze]

Before the fix, we were returning a message that a local file is newer than the remote one, which wasn't true.

This fix updates the shouldSkipDownload to return an additional value with a message in case it's different than the default one.

Also fixed a typo in readme regarding the minimum-perc flag.

Addresses #155

[kbairak]

Generally it's fine. I am approving this so if you want to discard my suggestion, go ahead and merge.

I don't like how the return values are inconsistent. Instead of (pseudocode in python-like language for speed):

def main():
    should_skip, msg = determine_if_should_skip()
    if should_skip:
        if msg:
            print(msg)
        else:
            print("Some default message")

def determine_if_should_skip():
    if some_condition:
        return True, ""
    elif some_other_condition:
        return True, "A very specific message"
    else:
        return False, ""

I think I would prefer

def main():
    should_skip, msg = determine_if_should_skip()
    if should_skip:
        print(msg)

def determine_if_should_skip():
    if some_condition:
        return True, "A default message"
    elif some_other_condition:
        return True, "A very specific message"
    else:
        return False, None

Yes this would mean that we would have to use the default message a few times inside the body of shouldSkipDownload but if this bothers you, you can define both messages as constant variables at the top of the function and use the variables when returning.

[codegaze]

@kbairak Nahh, good feedback. I didn't like something either. 🙏
Updated

[kbairak]

That works (again approving in case you want to discard), but...

Lets try:

func shouldSkipDownload(...) (bool, string, error) {
  const minimumThresholdMessage = "Minimum translation completion threshold not satisfied, skipping"
  const newerThanRemoteMessage = "Local file is newer than remote, skipping"

  if something {
    return true, minimumThresholdMessage, nil
  } else if somethingElse {
    return true, newerThanRemoteMessage, nil
  } else {
    return false, "", nil
  }
}