Merged
Conversation
e1843c7 to
dc3b13b
Compare
kbairak
reviewed
Nov 28, 2022
internal/txlib/pull.go
Outdated
Comment on lines
+377
to
+380
| if args.Pseudo { | ||
| sendMessage("Pseudo doesn't make sense for source files, skipping", false) | ||
| return | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@kbairak I wouldn't want to stop the whole process if someone added -s in the command along with others.
- If pseudo and source flags are there just ignore for source.
Does that make sense?
There was a problem hiding this comment.
It does, however, when you say tx pull -s -l fr we say that it doesn't make sense to have source with languages at the same time and abort the operation. I think it's better to let them know that they are doing something wrong instead of letting them think that their flags are taken into consideration and then have them discover that the results are not what they originally expected. Does this make sense?
Contributor
Author
There was a problem hiding this comment.
Yes yes, makes sense. Moved the condition to main :)
* Abort when source is used with pseudo * Pass `pseudo` fix for local files
dc3b13b to
8203d83
Compare
kbairak
approved these changes
Nov 29, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pseudofix for local files