Merged
Conversation
…ression-test-updates
…n-updates' into 994-usdm-4.0.0-regression-test-updates
…Children' into 994-usdm-4.0.0-regression-test-updates
hanp11
requested changes
Jul 25, 2025
src/TransCelerate.SDR.UnitTesting/CommonClassesUnitTesting/HelperV5ClassesUnitTesting.cs
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/CommonClassesUnitTesting/HelperV5ClassesUnitTesting.cs
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/ControllerUnitTesting/StudyV5ControllerUnitTesting.cs
Outdated
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/CommonClassesUnitTesting/HelperV5ClassesUnitTesting.cs
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/CommonClassesUnitTesting/HelperV5ClassesUnitTesting.cs
Outdated
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/ControllerUnitTesting/StudyV5ControllerUnitTesting.cs
Outdated
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/ControllerUnitTesting/StudyV5ControllerUnitTesting.cs
Outdated
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/ServicesUnitTesting/StudyServiceV5UnitTesting.cs
Outdated
Show resolved
Hide resolved
src/TransCelerate.SDR.UnitTesting/ServicesUnitTesting/StudyServiceV5UnitTesting.cs
Outdated
Show resolved
Hide resolved
…ression-test-updates
hanp11
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the 4.0.0 regression test data, taken from the CDISC_Pilot example from the RA repository.
Copied the V4 unit tests and then adapted them to work with the v4.0.0 regression test data.
In a few cases, there was a discrepancy between the UML model and the shape of the regression test data, this was usually because the data json contained just an ID reference to something, while the model had the actual object as a property rather than an ID reference. For a concrete example of this, the regression data json had AnalysisPopulationId property on the estimands, but in the model, estimands have an actual AnalysisPopulation as the property, not just the ID. I generally assumed that the model design was correct, and adjusted the data json to fit this. This is because looking at older versions of the JSON, this is how it has been done in the past, and it's also much easier than updating the model design.
While reviewing this, it may be easier to look at the commit history to see what changes were made to the json after copying in the raw data from the RA repository.
All regression tests are now running and passing.