feat: [#303] store in the database the torrent fields creation_date c… #315

mario-nt · 2023-09-26T13:38:12Z

Resolves #303.

codecov-commenter · 2023-09-26T13:51:44Z

Codecov Report

Merging #315 (7d9e887) into develop (aabd63c) will decrease coverage by 0.13%.
The diff coverage is 23.07%.

@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
- Coverage    42.47%   42.34%   -0.13%     
===========================================
  Files           79       79              
  Lines         4801     4822      +21     
===========================================
+ Hits          2039     2042       +3     
- Misses        2762     2780      +18

Files	Coverage Δ
src/services/torrent_file.rs	`100.00% <100.00%> (ø)`
src/databases/mysql.rs	`0.00% <0.00%> (ø)`
src/databases/sqlite.rs	`23.01% <0.00%> (-0.12%)`	⬇️
src/models/torrent.rs	`45.94% <0.00%> (-4.06%)`	⬇️
src/models/response.rs	`0.00% <0.00%> (ø)`
src/models/torrent_file.rs	`69.86% <0.00%> (-0.73%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

josecelano

It looks good!

josecelano · 2023-10-27T15:14:58Z

Hi @mario-nt this needs a rebase. I tried to do it with the GitHub UI, but commits are not verified.

mario-nt · 2023-10-30T20:32:14Z

@josecelano Rebase done and tests OK, we need to update the types and API libs before merging to make this PR work. I will update the types lib and then update the dependencies in the API lib.

josecelano · 2023-11-02T16:05:07Z

@josecelano Rebase done and tests OK, we need to update the types and API libs before merging to make this PR work. I will update the types lib and then update the dependencies in the API lib.

I've released the new types https://www.npmjs.com/package/torrust-index-types-lib/v/1.0.0-alpha.4

…_date created_by encoding API responses now contain the three field in the - Torrent details endpoint - Torrent list endpoint

…tion_date created_by encoding Fixed linting errors

…tion date created_by encoding Fix mysql type for creation_date column

… date created_by encoding Added bindings to the add torrent query in the mysql implementation for the new added fields

…tion date created by encoding -Added backticks for mysql so the encoding column name is not interpreted as a reserved keyword

mario-nt · 2023-11-09T16:36:29Z

@josecelano Ready to be merged.

josecelano · 2023-11-09T16:39:30Z

ACK c22f661

mario-nt temporarily deployed to coverage September 26, 2023 13:38 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 1c9e212 to 07cfb86 Compare September 27, 2023 15:15

mario-nt temporarily deployed to coverage September 27, 2023 15:15 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 07cfb86 to c302735 Compare September 27, 2023 22:02

mario-nt temporarily deployed to coverage September 27, 2023 22:02 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 28, 2023 12:10 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 28, 2023 12:11 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 28, 2023 17:24 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 28, 2023 17:25 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 28, 2023 22:28 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage September 29, 2023 10:23 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 4f57273 to cbbfe40 Compare September 29, 2023 10:25

mario-nt temporarily deployed to coverage September 29, 2023 10:25 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from cbbfe40 to 0866ae3 Compare September 29, 2023 21:34

mario-nt temporarily deployed to coverage September 29, 2023 21:35 — with GitHub Actions Inactive

mario-nt had a problem deploying to coverage September 29, 2023 21:35 — with GitHub Actions Failure

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 0866ae3 to 911c387 Compare September 29, 2023 21:41

mario-nt temporarily deployed to coverage September 29, 2023 21:41 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 911c387 to 078e086 Compare October 1, 2023 10:54

mario-nt temporarily deployed to coverage October 1, 2023 10:54 — with GitHub Actions Inactive

mario-nt temporarily deployed to coverage October 1, 2023 10:55 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 078e086 to bdc9932 Compare October 2, 2023 22:02

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 4993082 to af85b6a Compare October 4, 2023 22:59

mario-nt temporarily deployed to coverage October 4, 2023 22:59 — with GitHub Actions Inactive

mario-nt had a problem deploying to coverage October 4, 2023 22:59 — with GitHub Actions Failure

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from af85b6a to d6ea4a1 Compare October 20, 2023 16:52

mario-nt temporarily deployed to coverage October 20, 2023 16:52 — with GitHub Actions Inactive

josecelano approved these changes Oct 27, 2023

View reviewed changes

josecelano added the Needs Rebase Base Branch has Incompatibilities label Oct 27, 2023

josecelano force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from d6ea4a1 to 7d9e887 Compare October 27, 2023 15:13

josecelano temporarily deployed to coverage October 27, 2023 15:13 — with GitHub Actions Inactive

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 7d9e887 to 594a70a Compare October 30, 2023 19:57

mario-nt temporarily deployed to coverage October 30, 2023 19:57 — with GitHub Actions Inactive

josecelano added Needs Rebase Base Branch has Incompatibilities and removed Needs Rebase Base Branch has Incompatibilities labels Oct 31, 2023

MMelchor added 4 commits November 7, 2023 16:44

feat: [torrust#303] store in the database the torrent fields creation…

b738291

…_date created_by encoding API responses now contain the three field in the - Torrent details endpoint - Torrent list endpoint

refactor: [torrust#303] store in the database the torrent fields crea…

0a48536

…tion_date created_by encoding Fixed linting errors

refactor: [torrust#303] store in the database the torrent fields crea…

aadde22

…tion date created_by encoding Fix mysql type for creation_date column

feat: [torrust#303] store in the database the torrent fields creation…

c3d69f4

… date created_by encoding Added bindings to the add torrent query in the mysql implementation for the new added fields

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from 594a70a to e8772f3 Compare November 7, 2023 16:03

mario-nt had a problem deploying to coverage November 7, 2023 16:03 — with GitHub Actions Failure

josecelano mentioned this pull request Nov 8, 2023

Use stable toolchain for coverage.yml workflow #374

Closed

refactor: [torrust#303] store in the database the torrent fields crea…

c22f661

…tion date created by encoding -Added backticks for mysql so the encoding column name is not interpreted as a reserved keyword

mario-nt force-pushed the 303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding branch from e8772f3 to c22f661 Compare November 9, 2023 16:19

mario-nt temporarily deployed to coverage November 9, 2023 16:19 — with GitHub Actions Inactive

josecelano removed the Needs Rebase Base Branch has Incompatibilities label Nov 9, 2023

josecelano merged commit 41c80f3 into torrust:develop Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: [#303] store in the database the torrent fields creation_date c… #315

feat: [#303] store in the database the torrent fields creation_date c… #315

Uh oh!

mario-nt commented Sep 26, 2023

Uh oh!

codecov-commenter commented Sep 26, 2023 •

edited

Loading

Uh oh!

josecelano left a comment

Uh oh!

josecelano commented Oct 27, 2023

Uh oh!

mario-nt commented Oct 30, 2023

Uh oh!

josecelano commented Nov 2, 2023

Uh oh!

mario-nt commented Nov 9, 2023

Uh oh!

josecelano commented Nov 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: [#303] store in the database the torrent fields creation_date c… #315

feat: [#303] store in the database the torrent fields creation_date c… #315

Uh oh!

Conversation

mario-nt commented Sep 26, 2023

Uh oh!

codecov-commenter commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

josecelano left a comment

Choose a reason for hiding this comment

Uh oh!

josecelano commented Oct 27, 2023

Uh oh!

mario-nt commented Oct 30, 2023

Uh oh!

josecelano commented Nov 2, 2023

Uh oh!

mario-nt commented Nov 9, 2023

Uh oh!

josecelano commented Nov 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Sep 26, 2023 •

edited

Loading